-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zabbix_template - enable new update rule to delete missing linked templates #66747
Conversation
New update rule is available from 4.0.16 and 4.4.4 up. Add check for version and enable new update rule. fixes ansible#66720
The test
The test
|
Is there a way to rerun the shippable tests? |
@D3DeFi @sky-joker Could you please review this? |
Thank you @rockaut for reporting and patch the issues!
You need to close and open this PR. |
I updated the version checks. It's not pretty or efficient but also not too shabby imo. Can someone check it against a 4.2 branch. I don't have one at hand. |
works for me, thanks shipit |
Why is this one check (#60) always "unstable"? I don't get it. It says something about mysql ...
|
If I am not mistaken, integration testing workflow should go like this (note that every integration role has its own generated play):
Problem probably resides at the step 4. I would start searching there as there may be something that should be cleaned up after mysql daemon, but currently is not, preventing second installation of mysql on the same container from starting correctly. Shame on me as I've met this error more than once, but never really tried to dive deeper into it as close & reopen of PR was quicker atm for me, but shortsighted. Lets see If I can come up with something for it today and open a PR for mysql maintainers. |
Thank you @D3DeFi ... ping me if I have something to do. |
@rockaut please try to close & reopen this PR until CI build passes. No need for this PR to wait for fixes meant for setup_mysql_db. |
temporary close for pipeline fixes |
reopen for pipeline build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit
Looks good to me :) shipit |
SUMMARY
New update rule is available from 4.0.16 and 4.4.4 up. Add check for version and enable new update rule.
fixes #66720
ISSUE TYPE
COMPONENT NAME
zabbix_template
ADDITIONAL INFORMATION
Using new update rule set to true, linked templates getting unlinked if removed from xml/json files.